add react 18 hooks #3598
Merged
add react 18 hooks #3598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +306 B (0%) Total Size: 38.3 kB
ℹ️ View Unchanged
|
marvinhagemeister
approved these changes
Jul 5, 2022
Closed
mayank99
reviewed
Jul 8, 2022
Comment on lines
+147
to
+151
| useEffect(() => { | ||
| return subscribe(() => { | ||
| setState(getSnapshot()); | ||
| }); | ||
| }, [subscribe, getSnapshot]); |
There was a problem hiding this comment.
I came across this PR when I was looking into React 18 support in compat. Just wondering, shouldn't the state be set before subscribing? 🤔
Suggested change
| useEffect(() => { | |
| return subscribe(() => { | |
| setState(getSnapshot()); | |
| }); | |
| }, [subscribe, getSnapshot]); | |
| useEffect(() => { | |
| const callback = () => setState(getSnapshot()); | |
| callback(); | |
| return subscribe(callback); | |
| }, [subscribe, getSnapshot]); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like #3568 misses
useId