Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix allow return undefined in useMemo after skipped render #3580

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Fix allow return undefined in useMemo after skipped render #3580

merged 1 commit into from
Jun 21, 2022

Conversation

marvinhagemeister
Copy link
Member

No description provided.

@github-actions
Copy link

Size Change: +34 B (0%)

Total Size: 42.9 kB

Filename Size Change
hooks/dist/hooks.js 1.25 kB +10 B (0%)
hooks/dist/hooks.module.js 1.26 kB +11 B (0%)
hooks/dist/hooks.umd.js 1.33 kB +13 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.48 kB 0 B
compat/dist/compat.module.js 3.47 kB 0 B
compat/dist/compat.umd.js 3.54 kB 0 B
debug/dist/debug.js 3 kB 0 B
debug/dist/debug.module.js 3 kB 0 B
debug/dist/debug.umd.js 3.08 kB 0 B
devtools/dist/devtools.js 231 B 0 B
devtools/dist/devtools.module.js 239 B 0 B
devtools/dist/devtools.umd.js 307 B 0 B
dist/preact.js 4.03 kB 0 B
dist/preact.min.js 4.06 kB 0 B
dist/preact.module.js 4.05 kB 0 B
dist/preact.umd.js 4.1 kB 0 B
jsx-runtime/dist/jsxRuntime.js 317 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 395 B 0 B
test-utils/dist/testUtils.js 444 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 521 B 0 B

compressed-size-action

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 21, 2022 •
edited

Size Change: +34 B (0%)

Total Size: 42.9 kB

Filename Size Change
hooks/dist/hooks.js 1.25 kB +10 B (0%)
hooks/dist/hooks.module.js 1.26 kB +11 B (0%)
hooks/dist/hooks.umd.js 1.33 kB +13 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.48 kB 0 B
compat/dist/compat.module.js 3.47 kB 0 B
compat/dist/compat.umd.js 3.54 kB 0 B
debug/dist/debug.js 3 kB 0 B
debug/dist/debug.module.js 3 kB 0 B
debug/dist/debug.umd.js 3.08 kB 0 B
devtools/dist/devtools.js 231 B 0 B
devtools/dist/devtools.module.js 239 B 0 B
devtools/dist/devtools.umd.js 307 B 0 B
dist/preact.js 4.03 kB 0 B
dist/preact.min.js 4.06 kB 0 B
dist/preact.module.js 4.05 kB 0 B
dist/preact.umd.js 4.1 kB 0 B
jsx-runtime/dist/jsxRuntime.js 317 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 395 B 0 B
test-utils/dist/testUtils.js 444 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 521 B 0 B

compressed-size-action

@marvinhagemeister
Copy link
Member Author

Improved test case courtesy of @JoviDeCroock 💯

@marvinhagemeister marvinhagemeister merged commit 5e010c5 into master Jun 21, 2022
@marvinhagemeister marvinhagemeister deleted the skipped-memo branch June 21, 2022 20:30
@coveralls
Copy link

coveralls commented Jun 21, 2022 •
edited

Coverage Status

Coverage increased (+0.001%) to 99.446% when pulling 8fb0923 on skipped-memo into d2cc99b on master.

@JoviDeCroock JoviDeCroock mentioned this pull request Jun 22, 2022
Merged
@rburgstaller rburgstaller mentioned this pull request Jun 22, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marvinhagemeister @coveralls @JoviDeCroock