Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _pendingValue to mangle.json #3575

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Conversation

marvinhagemeister
Copy link
Member

@marvinhagemeister marvinhagemeister commented Jun 20, 2022

PR #3567 added a new property to hooks for pending state. Devtools needs to be able to access these to be able to show them in the sidebar. With this PR we ensure that devtools can rely on a consistent name to access it.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.446% when pulling 079f9a6 on pending_mangle-name into e9c8d1c on master.

@JoviDeCroock
Copy link
Member

Do you need _pendingArgs too?

@marvinhagemeister
Copy link
Member Author

@JoviDeCroock good catch! Just checked and devtools doesn't need to read _args or _pendingArgs. It just grabs the values directly.

@marvinhagemeister marvinhagemeister merged commit 894f7ba into master Jun 20, 2022
@marvinhagemeister marvinhagemeister deleted the pending_mangle-name branch June 20, 2022 22:21
@JoviDeCroock JoviDeCroock mentioned this pull request Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants