Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make createRoot / hydrateRoot compatible with React spec #3560

Merged
merged 1 commit into from
Jun 12, 2022
Merged

make createRoot / hydrateRoot compatible with React spec #3560

merged 1 commit into from
Jun 12, 2022

Conversation

3846masa
Copy link
Contributor

JoviDeCroock
JoviDeCroock reviewed Jun 11, 2022
View reviewed changes
compat/client.js Outdated Show resolved Hide resolved
@3846masa
Copy link
Contributor Author

@JoviDeCroock
Thanks for the review. I changed the code and rebased it.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.444% when pulling e337bc8 on 3846masa-tmp:feat/new-root-api-compat into 1dc4f56 on preactjs:master.

@JoviDeCroock JoviDeCroock merged commit 2834d5a into preactjs:master Jun 12, 2022
@JoviDeCroock JoviDeCroock mentioned this pull request Jun 14, 2022
Merged
@JoviDeCroock JoviDeCroock mentioned this pull request Jun 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@3846masa @coveralls @JoviDeCroock