Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move preact-render-to-string to preact/server #3480

Merged
merged 365 commits into from
Mar 16, 2022
Merged

Conversation

marvinhagemeister
Copy link
Member

@marvinhagemeister marvinhagemeister commented Mar 15, 2022

This PR merges the https://github.com/preactjs/preact-render-to-string repo into core under preact/server. All commits from that repo are preserved and all tags have been renamed to server-x.x.x.

On top of that there are a few commits that integrate the tooling into our main one. It has not been updated for internals yet, so I've skipped a few tests. The tests can be run via npm run test:mocha:server

developit and others added 30 commits February 14, 2017 13:49
When styles object is empty don’t render style attribute
- Try to mimic the Preact TSD.

- Example usage with `noImplicitAny` enabled:

  import { render } from "preact-render-to-string";

- No idea if I've done it right but it seems to compile and hopefully
  someone more knowledgeable can build on this.
* Correct & simplify component name detection (Fixes #44)

* fix me being silly
@coveralls
Copy link

coveralls commented Mar 15, 2022

Coverage Status

Coverage remained the same at 99.708% when pulling 20a668a on render-to-string into a69f287 on main.

@github-actions
Copy link

github-actions bot commented Mar 15, 2022

Size Change: 0 B

Total Size: 38.6 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.67 kB 0 B
compat/dist/compat.umd.js 3.74 kB 0 B
debug/dist/debug.js 3.26 kB 0 B
debug/dist/debug.umd.js 3.33 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.umd.js 316 B 0 B
dist/preact.js 4.73 kB 0 B
dist/preact.min.js 4.78 kB 0 B
dist/preact.umd.js 4.83 kB 0 B
hooks/dist/hooks.js 1.33 kB 0 B
hooks/dist/hooks.umd.js 1.4 kB 0 B
jsx-runtime/dist/jsxRuntime.js 342 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 425 B 0 B
server/dist/server.js 2.6 kB 0 B
server/dist/server.umd.js 2.69 kB 0 B
test-utils/dist/testUtils.js 431 B 0 B
test-utils/dist/testUtils.umd.js 516 B 0 B

compressed-size-action

server/README.md Outdated Show resolved Hide resolved
{
"name": "preact-server",
"amdName": "preactServer",
"version": "5.1.20",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we publishing this separately or are we going to keep this at its own version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can safely ignore this as the plan is to publish this as part of core and not as a separate package. The other addons have bogus version numbers to which don't match the same package. So far we haven't gotten an issue for that so I'm assuming that no tool reads it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.