Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) - nested setState calls with accurate this.state #1748

Merged
merged 5 commits into from
Sep 9, 2019
Merged

(fix) - nested setState calls with accurate this.state #1748

merged 5 commits into from
Sep 9, 2019

Conversation

JoviDeCroock
Copy link
Member

Adds 7bytes to the main package
Fixes: #1741

@JoviDeCroock JoviDeCroock mentioned this pull request Jul 1, 2019
Closed
@coveralls
Copy link

coveralls commented Jul 1, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 99.882% when pulling b5832ae on fix/nestedSetStateCb into 74074a3 on master.

edimitchel
edimitchel approved these changes Jul 1, 2019
View reviewed changes
Copy link

@edimitchel edimitchel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM !

developit
developit reviewed Jul 9, 2019
View reviewed changes
src/diff/index.js Show resolved Hide resolved
test/browser/components.test.js Show resolved Hide resolved
@edimitchel
Copy link

edimitchel commented Jul 29, 2019 •
edited
Loading

Is there any hope of getting this correction before the release of the stable version of Preact X?
In any case, thanks a lot for your hard work !
@developit ?

@marvinhagemeister
Copy link
Member

@edimitchel I've actually come across a project which had a minor but valid use case for nesting setState. So we're merging this one here 🎉

marvinhagemeister
marvinhagemeister approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after seeing a use case I'm fine with merging this 👍

@marvinhagemeister marvinhagemeister merged commit e44eed5 into master Sep 9, 2019
@marvinhagemeister marvinhagemeister deleted the fix/nestedSetStateCb branch September 9, 2019 18:03
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Nov 10, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit left review comments

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@edimitchel edimitchel edimitchel approved these changes

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

@cristianbote cristianbote Awaiting requested review from cristianbote

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Callback on nested setState doesn't called with update state
6 participants
@JoviDeCroock @coveralls @edimitchel @marvinhagemeister @developit @cristianbote