-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dom class value lost in a special case #181
Comments
Good catch. I believe this line is the suspect: |
Ahh - @zhenkunou looks like this is specific to |
Fix released in |
I've updated the demo(5.0.0-beta10), it work now!! Great, thank you. |
marvinhagemeister
added a commit
that referenced
this issue
Mar 15, 2022
Perf: Improve HTML entity escaping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
hi~ @developit
in this codepen:
http://codepen.io/ryan_ou/pen/rLOaJa?editors=0010 (5.0.0-beta9)
follow these steps you will see the issue:
it should be:
If you change the vnode(id='panel') to be:
the class will be correct.
It seems like that:
If a
component.className
has been set tonull/undefined/''
;a dom's class will lost when preact re-use the
component.base
The text was updated successfully, but these errors were encountered: