SVG viewBox attribute is incorrectly applied

[marklundin]

When a component renders different svg elements depending on it's state, it will incorrectly apply the viewBox attribute from the first svg element rendered to the second.

Test case : https://jsfiddle.net/jdqhus9m/

1. First SVG is displayed with viewBox="50 0 50 50" attribute displaying a green rect.
2. Click on the SVG element to trigger a state change, rendering a different svg without the viewbox attribute. Notice in the dom, that the new svg contains the viewBox="50 0 50 50" attribute from the first render.

Expected result: SVG element should have no viewBox attribute and should display the red and greenbox side by side.

[developit]

Thanks for the detailed bug report! I'm thinking it's failing to set the property but the error is being caught and suppressed. I can't check now, but maybe it's fixed in https://npmcdn.com/preact@beta ?

[marklundin]

Awesome. Will check in the morning and let you know

[developit]

@marklundin This ended up being a bug in preact-svg. It's now fixed, released as [email protected]. Thanks again :)

[marklundin]

Great work @developit !