Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional components break *mount methods #175

Closed
slmgc opened this issue Jun 4, 2016 · 2 comments
Closed

Functional components break *mount methods #175

slmgc opened this issue Jun 4, 2016 · 2 comments

Comments

@slmgc
Copy link
Contributor

slmgc commented Jun 4, 2016

I've created an example with a higher-order component which gets broken when it wraps a functional component which returns a class component... I think we need to go deeper:

http://codepen.io/anon/pen/RRPMVr

Constructors for Composed & Broken components get executed, but Broken's componentDidMount, componentWillMount, componentWillUnmount, etc. methods don't get executed.

And all is ok if I'll replace a functional component with a class component.

@developit
Copy link
Member

Thanks for investigating this! I think I know what's causing it and will publish a new beta today. I believe you're running 5.0.0-beta6?

@slmgc
Copy link
Contributor Author

slmgc commented Jun 4, 2016

@developit yeah, I was playing with beta6 and reproduced this issue.

slmgc added a commit to ekorzun/react-template that referenced this issue Jun 4, 2016
slmgc added a commit to ekorzun/react-template that referenced this issue Jun 7, 2016
slmgc added a commit to ekorzun/react-template that referenced this issue Jun 7, 2016
marvinhagemeister added a commit that referenced this issue Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants