-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functional components break *mount methods #175
Comments
Thanks for investigating this! I think I know what's causing it and will publish a new beta today. I believe you're running 5.0.0-beta6? |
@developit yeah, I was playing with beta6 and reproduced this issue. |
slmgc
added a commit
to ekorzun/react-template
that referenced
this issue
Jun 4, 2016
slmgc
added a commit
to ekorzun/react-template
that referenced
this issue
Jun 7, 2016
slmgc
added a commit
to ekorzun/react-template
that referenced
this issue
Jun 7, 2016
marvinhagemeister
added a commit
that referenced
this issue
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've created an example with a higher-order component which gets broken when it wraps a functional component which returns a class component... I think we need to go deeper:
http://codepen.io/anon/pen/RRPMVr
Constructors for Composed & Broken components get executed, but Broken's componentDidMount, componentWillMount, componentWillUnmount, etc. methods don't get executed.
And all is ok if I'll replace a functional component with a class component.
The text was updated successfully, but these errors were encountered: