-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
componentWillMount not triggering under certain scenarios #129
Comments
@impronunciable I might have fixed this with 4.7.1. I found a regression in |
not working for me event after update. |
Alright, I'll get some tests around this. Going to need to queue some lifecycle events, there are 3 open issues relating to their timing now. |
Confirmed this is a bug, so I'm holding off on any releases until I have a complete fix in place. Hopefully very very soon! |
Confirmed fix for this coming shortly! |
This should be fixed in 5.0.0-beta1 :) |
Fix verification: http://codepen.io/developit/pen/reXZvd?editors=0010 |
Hi, I'm using
preact-router
along withreact-redux
. As @developit pointed, this check is the problem https://github.com/developit/preact/blob/master/src/vdom/component.js#L131Removing the if did the trick and triggered componentWillMount. This is my scenario https://github.com/impronunciable/hackdash-front/blob/master/src/containers/Dashboard.js#L8
The text was updated successfully, but these errors were encountered: