Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

componentWillMount not triggering under certain scenarios #129

Closed
impronunciable opened this issue Apr 18, 2016 · 7 comments
Closed

componentWillMount not triggering under certain scenarios #129

impronunciable opened this issue Apr 18, 2016 · 7 comments

Comments

@impronunciable
Copy link
Contributor

Hi, I'm using preact-router along with react-redux. As @developit pointed, this check is the problem https://github.com/developit/preact/blob/master/src/vdom/component.js#L131

Removing the if did the trick and triggered componentWillMount. This is my scenario https://github.com/impronunciable/hackdash-front/blob/master/src/containers/Dashboard.js#L8

@developit
Copy link
Member

@impronunciable I might have fixed this with 4.7.1. I found a regression in 4.6.2 a case very similar to the one you encountered. Let me know if it's fixed :)

@impronunciable
Copy link
Contributor Author

not working for me event after update.

@developit
Copy link
Member

Alright, I'll get some tests around this. Going to need to queue some lifecycle events, there are 3 open issues relating to their timing now.

@developit
Copy link
Member

Confirmed this is a bug, so I'm holding off on any releases until I have a complete fix in place. Hopefully very very soon!

@developit
Copy link
Member

Confirmed fix for this coming shortly!

@developit
Copy link
Member

This should be fixed in 5.0.0-beta1 :)

@developit developit added this to the 5.0 milestone May 23, 2016
@developit
Copy link
Member

Fix verification: http://codepen.io/developit/pen/reXZvd?editors=0010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants