Skip to content

Commit

Permalink
try to fix benchmarks
Browse files Browse the repository at this point in the history
  • Loading branch information
JoviDeCroock committed Mar 17, 2024
1 parent dc55841 commit a456819
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
needs: build
steps:
- uses: actions/checkout@v4
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: npm-package
- name: Create draft release
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/run-bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
node-version-file: 'package.json'
cache: 'npm'
cache-dependency-path: '**/package-lock.json'
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: bench-environment
- name: Install deps
Expand All @@ -49,7 +49,7 @@ jobs:
export CHROMEDRIVER_FILEPATH=$(which chromedriver)
npm run bench ${{ inputs.benchmark }}.html -- --trace=${{ inputs.trace }}
- name: Upload results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: results
path: benches/results/${{ inputs.benchmark }}.json
Expand All @@ -60,7 +60,7 @@ jobs:
working-directory: benches
run: '[ -d logs ] && tar -zcvf ${{ inputs.benchmark}}_logs.tgz logs || echo "No logs found"'
- name: Upload logs
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ inputs.benchmark}}_logs
path: benches/${{ inputs.benchmark}}_logs.tgz
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/single-bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@ jobs:
timeout-minutes: 5
steps:
- name: Download locally built preact package
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: npm-package
- run: mv preact.tgz preact-local.tgz
- name: Upload locally built preact package
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: bench-environment
path: preact-local.tgz
Expand All @@ -73,7 +73,7 @@ jobs:
echo "===================="
ls -al
- name: Download base package
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: base-npm-package
- run: mv preact.tgz preact-main.tgz
Expand Down
2 changes: 1 addition & 1 deletion src/render.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export function render(vnode, parentDom, replaceNode) {
isHydrating,
refQueue
);

// test
// Flush all queued effects
commitRoot(commitQueue, vnode, refQueue);
}
Expand Down

0 comments on commit a456819

Please sign in to comment.