Fixed 404 handling in app generator. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -198,6 +198,9 @@ RUBY | |||
| # media_type media_type | |||
| # end | |||
| Praxis::ApiDefinition.define do | |||
| response_template :not_found do | |||
There was a problem hiding this comment.
there's no need to define the not_found template, as it is given by the framework.
But! for such a simple app, the autoloader is being too lazy so by the time the resource definition is read the template is not yet registered (i.e. this is a bug).
I've pushed a change that solve the issue. So if you don't mind pulling the latest code and resubmitting the PR without this template block?
Return 404 instead of 500 for show action on unknown resource id. Signed-off-by: Magne Land <[email protected]>
Signed-off-by: Magne Land <[email protected]>
magneland
force-pushed
the
10-fix_app_generator
branch
from
b1ac6da to
ed0748f
Compare
|
Thank you Magne! |
blanquer
added a commit
that referenced
this pull request
Aug 27, 2014
Fixed 404 handling in app generator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return 404 instead of 500 for show action on unknown resource id.
Signed-off-by: Magne Land [email protected]