Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #1343 #1345

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for issue #1343 #1345

wants to merge 2 commits into from

Conversation

afdev82
Copy link

@afdev82 afdev82 commented Mar 19, 2024

Fallback to 0.0 in case of no gutter

andreavocado
andreavocado reviewed Apr 12, 2024
View reviewed changes
Copy link

@andreavocado andreavocado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are specs missing when options is empty or options[:*gutter] is nil.

lib/prawn/grid.rb Outdated Show resolved Hide resolved
lib/prawn/grid.rb Outdated Show resolved Hide resolved
lib/prawn/grid.rb Outdated Show resolved Hide resolved
@afdev82
Copy link
Author

afdev82 commented Apr 12, 2024

Yes, then I will add the specs.

@afdev82 @andreavocado
fallback to 0.0 in case of no gutter, fixes prawnpdf#1343
bc5375d 
Prefer fetch for default value

Co-authored-by: André Jährling <[email protected]>
@afdev82
Copy link
Author

afdev82 commented Apr 30, 2024

I have added a simple test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreavocado andreavocado andreavocado left review comments

@pointlessone pointlessone pointlessone left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afdev82 @pointlessone @andreavocado