Bump prawcore dependency version #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praw 7.8.0 uses the window_core attribute of prawcore.session, which was added in version 2.4.0.
LilSpazJoekp
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Summary and Justification
This pull request updates pyproject.toml to require a prawcore version 2.4.0 or later. praw 7.8.0 uses the window_core attribute of prawcore.session when initializing an instance of praw.Reddit, which does not exist before version 2.4.0. Although this discrepancy does not cause issues with fresh installs of praw, it may affect users who are upgrading from older version installed before the release of prawcore 2.4.0.
References
praw/praw/reddit.py
Line 553 in fdb847e