Accept Dynamic Entries and RuntimeChunks #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azizhk
changed the title
|
Thanks for this work :) Can you post a small sample |
|
I'll add tests itself. |
|
I've added the tests. I might have gone overboard with the various configs, so let me know and I'll delete whatever is unnecessary. A few files are the same. I don't know if I should de-duplicate or let them be? These files would have to be split if webpack modifies it's runtime to use es2015+ features (highly unlikely). |
prateekbh
approved these changes
Jun 17, 2019
|
This looks great thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm trying to integrate this plugin with next.js (vercel/next.js#7563)
Next.js has Dynamic Entries, Webpack Documentation
Source:
https://github.com/zeit/next.js/blob/a71cb644b5b7f45521d7a49f5cfca171b3d81a1e/packages/next/build/webpack-config.ts#L336-L341
So had to make a few changes.