Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposed feedback comments #11

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

proposed feedback comments #11

wants to merge 4 commits into from

Conversation

prashantgupta24
Copy link
Owner

@prashantgupta24 prashantgupta24 commented Sep 4, 2020 •
edited
Loading

Feedback comments being targeted:

  1. Removing local db, all IPs will be fetched directly from the firewall rules.
  2. Validation of IPv4 address before adding

Update

I am thinking whether removing the db is a good idea or not, since the db helps me keep the domain along with the IP address. Removing db will just give me a list of IP addresses, without having any other metadata about them.

@prashantgupta24 prashantgupta24 marked this pull request as draft September 5, 2020 21:00
@prashantgupta24 prashantgupta24 changed the title feedback comments proposed feedback comments Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@prashantgupta24