Incorrect registry access on several versions of x86 POP #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-fix operand access of three mov instructions
Synch with upstream
The python script for generating constants in the bindings does not know how to handle the #if 0 statements included in these files.
Pulling from upstream
Registry access for the destination operand of the conditional move (cmov) opcodes were incorrectly listed as READ | WRITE. Although you would expect the two operands to be compared in this opcode, it instead relies on the associated flag in EFLAGS regardless of the value in the destination operand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several of the special versions of POP such as POPDS, POPSS, etc list the operand as ignore instead of write. Pull request capstone-engine#1725 corrects the issue.
Actual cstool output for POPDS (note missing WRITE on operand[0]):
./cstool -d x32 "1f"
0 1f pop ds
Prefix:0x00 0x00 0x00 0x00
Opcode:0x1f 0x00 0x00 0x00
rex: 0x0
addr_size: 4
modrm: 0x0
disp: 0x0
sib: 0x0
op_count: 1
operands[0].type: REG = ds
operands[0].size: 2
Groups: privilege not64bitmode
Expected output from cstool for POPDS (note inclusion of WRITE on operand[0]):
./cstool -d x32 "1f"
0 1f pop ds
Prefix:0x00 0x00 0x00 0x00
Opcode:0x1f 0x00 0x00 0x00
rex: 0x0
addr_size: 4
modrm: 0x0
disp: 0x0
sib: 0x0
op_count: 1
operands[0].type: REG = ds
operands[0].size: 2
operands[0].access: WRITE
Registers modified: ds
Groups: privilege not64bitmode