Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix map interaction #43

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Fix map interaction #43

merged 3 commits into from
Jan 20, 2022

Conversation

oobug
Copy link
Contributor

@oobug oobug commented Jan 17, 2022

The interactive map features are not working. This pull request fixes the following capabilities:

  • show food trucks from search results on the map
  • hover over search results and highlight corresponding points
  • click on points for a data popup

The build/main.js and build/main.js.map have been updated to ensure future students do not need to learn webpack.

Some fixes borrowed from @reneab in #35

@oobug oobug mentioned this pull request Jan 17, 2022
Open
@prakhar1989 prakhar1989 merged commit 9b80c64 into prakhar1989:master Jan 20, 2022
@prakhar1989
Copy link
Owner

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oobug @prakhar1989