fix(startup): suppress drained invalid-secondmate-home diagnostic per fingerprint - #162
Merged
Merged
Conversation
… fingerprint The invalid marker diagnostic used publish_actionable alone, so a persistent marker re-woke on every startup scan after its drain. Queue it through a per-fingerprint diagnostic record with queue_notice_once instead, and retire the record on a healthy scan, so a changed marker or a repaired-then-invalid home wakes again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The invalid marker diagnostic used publish_actionable alone, so a persistent marker re-woke on every startup scan after its drain. Queue it through a per-fingerprint diagnostic record with queue_notice_once instead, and retire the record on a healthy scan, so a changed marker or a repaired-then-invalid home wakes again. Proved by test_invalid_secondmate_marker_wake_does_not_rewake_after_drain, which fails on the base code.