Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charging indicator #944

Closed
wants to merge 0 commits into from
Closed

charging indicator #944

wants to merge 0 commits into from

Conversation

GabriWar
Copy link
Contributor

@GabriWar GabriWar commented Mar 18, 2025

Added a simple charging indicator (tested on Tembed CC1101). It should be around 15 lines of code.

Left the validating code out of the #ifdef so additional batteries can be added later.

It also defaults to false, so it should not break any other function calls.

it takes 30sec to check and refresh the icon, but you cn kinda force it fo refresh by trying to enter deepsleep and canceling it before the 3 2 1 countdown with esc + right

@GabriWar GabriWar changed the title batter charging indicator Mar 18, 2025
@GabriWar
Copy link
Contributor Author

1742325586927
preview

@GabriWar
Copy link
Contributor Author

maybe set it to red if battery is below 30? 🤔

@bmorcelli
Copy link
Collaborator

it already exists and works

@bmorcelli bmorcelli closed this Mar 18, 2025
@bmorcelli bmorcelli reopened this Mar 18, 2025
@bmorcelli
Copy link
Collaborator

Oh, Now I understand.. lol.. it is to show if it is charging
Sorry

@bmorcelli
Copy link
Collaborator

I believe it would, for now, be better to have a function on interface.h and implemented on device interface.cpp to determine if it is charging or not, because the other devices relies on axp or other power chips .

Same way we have for the battery value.

When we have the HAL thing, it might be taken from there

@GabriWar
Copy link
Contributor Author

hmm, i saw the HAL pr, so may worth it to postpone until it gets merged?
if im understanding it right it should help alleviate the need to use different functions to different hardware, right?

@bmorcelli
Copy link
Collaborator

This is the idea.. bring the hardware level code into the project and do not make lots of programming to port devices over.

But idk when it will be available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants