Add back right-click-for-new-combo and right-click-delete when in object placement mode #31148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe it could work by making Maybe worth trying. Not sure. |
peppy
force-pushed
the
editor-right-click-as-people-expect
branch
from
ad74b83 to
270e278
Compare
|
Looking back at this I'm thinking the flow I had was already fine to go ahead with, so I'll work with that in mind (and just fix tests). |
…pose mode Requested too many times to count. I'm not sure what to do about the code quality of this. It's a bit weird that there's no way to check the current composition tool from a higher level. Also it was discussed IRL that there should be some kind of hinting that existing notes will be deleted when they are hovered, but I'm not sure how well this will work in normal mapping flows, since it will display even in cases that users aren't intending to delete an object. Still willing to explore this direction though (it's just non-trivial to implement so I haven't yet).
peppy
force-pushed
the
editor-right-click-as-people-expect
branch
from
270e278 to
896caf4
Compare
bdach
changed the title
bdach
requested changes
Feb 27, 2025
Comment on lines
+357
to
+363
| if (e.Button == MouseButton.Right) | ||
| { | ||
| var osuSelectionHandler = (OsuSelectionHandler)BlueprintContainer.SelectionHandler; | ||
|
|
||
| osuSelectionHandler.SelectionNewComboState.Value = | ||
| osuSelectionHandler.SelectionNewComboState.Value == TernaryState.False ? TernaryState.True : TernaryState.False; | ||
| } |
There was a problem hiding this comment.
Several issues with this.
- On a code organisation level, why is this pulled two levels up from
OsuSelectionHandlertoOsuHitObjectComposer, rather than being inOsuSelectionHandler? - Quick-deleting anything will also simultaneously toggle new combo which I assume is not intended.
2025-02-27.14-16-10.mp4
- Right clicking an object to open the context menu will toggle new combo which I assume is not intended. Selecting it and then right clicking it anywhere else will also toggle new combo, which I'm not sure if that's intended, but it does at least feel a little weird.
2025-02-27.14-17-10.mp4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested too many times to count.
I'm not sure what to do about the code quality of this. It's a bit weird that there's no way to check the current composition tool from a higher level.
Also it was discussed IRL that there should be some kind of hinting that existing notes will be deleted when they are hovered, but I'm not sure how well this will work in normal mapping flows, since it will display even in cases that users aren't intending to delete an object. Still willing to explore this direction though (it's just non-trivial to implement so I haven't yet).
This is almost definitely not going to pass tests, just want to get this out for initial thoughts before I polish things up.