Show an ongoing operation when checking for updates #30953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #30950.
Thought this would be a quick one, but during testing I noticed an unobserved exception could lead to a failure (even on
master
). Also, if the settings overlay was closed during the update check, theSchedule
in theContinueWith
would not run (as the settings panel is not present).I've fixed both issues by using the (relatively unused)
SynchronizationContext
presence, which means the continuation will be automatically scheduled back to the update thread (since it was triggered from that thread).Can be tested using some iteration of: