Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strong drum rolls being counted for double the combo in legacy scoring attributes #30917

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Fix strong drum rolls being counted for double the combo in legacy scoring attributes #30917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions osu.Game.Rulesets.Taiko/Difficulty/TaikoLegacyScoreSimulator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,13 @@ private void simulateHit(HitObject hitObject, ref LegacyScoreAttributes attribut
foreach (var nested in hitObject.NestedHitObjects)
simulateHit(nested, ref attributes);
return;

case StrongNestedHitObject:
// we never need to deal with these directly.
// the only thing strong hits do in terms of scoring is double their object's score increase,
// which is already handled at the parent object level via the `strongable.IsStrong` check lower down in this method.
// not handling these here can lead to them falsely being counted as combo-increasing when handling strong drum rolls!
return;
}

if (hitObject is DrumRollTick tick)
Expand Down
Loading