Centralise supported file extensions to one helper class #30915
Conversation
| public static readonly string[] ALL_EXTENSIONS = | ||
| [ | ||
| ..VIDEO_EXTENSIONS, | ||
| ..AUDIO_EXTENSIONS, | ||
| ..IMAGE_EXTENSIONS | ||
| ]; |
There was a problem hiding this comment.
Primer for what this is: https://learn.microsoft.com/en-us/dotnet/csharp/whats-new/csharp-12#collection-expressions
I find this to be a compelling usage of the syntax because any other way to write it in C# is veeeeeeeeeery clunky, but I will go the clunky route if usage of this syntax is considered not wanted.
There was a problem hiding this comment.
I personally think it's fine as it shortens code while not looking extremely odd.
| { | ||
| Caption = GameplaySettingsStrings.BackgroundHeader, | ||
| PlaceholderText = EditorSetupStrings.ClickToSelectBackground, | ||
| }, | ||
| audioTrackChooser = new FormFileSelector(".mp3", ".ogg") | ||
| // `SupportedExtensions.AUDIO_EXTENSIONS` not used here specifically because it includes `.wav` for samples, which is strictly disallowed by ranking criteria |
There was a problem hiding this comment.
Dunno, I think it's probably fine to leave it on the user to get this right and we could just allow it (I think stable would, but no one has done a silly here).
There was a problem hiding this comment.
I initially thought the same but then reverted it after checking RC and seeing it explicitly spelled out there. I think we should strive to make it literally impossible for users to breach RC via in-game means when it comes to such matters, but am not strongly against using the helper.
RFC. As proposed in ppy/osu-server-beatmap-submission#5 (comment).