Add a toggle for star fountains during gameplay

[HenintsoaSky]

• Addresses Add setting to disable kiai star effect in gameplay #29830

Adds an option under Gameplay > General Settings that allows users to enable/disable star fountains during gameplay.

[frenzibyte]

Thanks for the contribution!

We generally avoid adding new options to the settings without a convincing reason to do so, has there been any discussion elsewhere prior to the submission of this PR?

[HenintsoaSky]

In : #29830

[peppy]

For added context, this was done until now by skins making transparent images for the star sprite. Which isn't optimal as it means stars disappear from everywhere in the game.

Not strongly against this one existing.

[Joehuu]

Just noting there was an alternative solution in #29792 (comment).

[frenzibyte]

Usually we would hold off such PRs until we have top-level skin settings in that case (similar to the yet-to-exist "hide perfect judgements" setting), but I'll be of the opinion on getting this one in given the argument of "I want my star fountains everywhere else except in gameplay" as mentioned in #30894 (comment) / #29792 (reply in thread), which cannot be resolved with any kind of user-side legacy skin hackery.

[peppy]

Just noting there was an alternative solution in #29792 (comment).

That's why this felt so familiar.

"Alternative" sure that's one way of looking at it 😅

Usually we would hold off such PRs until we have top-level skin settings

This is a user preference, not a skin setting. Skins should be providing every resource and it should be up to users to disable them.