Fix mania notes disappearing on seek to their end time #30755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
commented
Nov 18, 2024
| @@ -82,6 +85,9 @@ public ManiaPlayfield(List<StageDefinition> stageDefinitions) | |||
| } | |||
| } | |||
|
|
|||
| [Pure] | |||
There was a problem hiding this comment.
This annotation is supposed to assuage doubts that may pop up from the "virtual call in ctor" hint-level inspections resulting from this change.
Comment on lines
+138
to
+145
| var action = columnStartAction; | ||
| columnStartAction++; | ||
| var column = CreateColumn(firstColumnIndex + i, isSpecial).With(c => | ||
| { | ||
| RelativeSizeAxes = Axes.Both, | ||
| Width = 1, | ||
| Action = { Value = columnStartAction++ } | ||
| }; | ||
| c.RelativeSizeAxes = Axes.Both; | ||
| c.Width = 1; | ||
| c.Action.Value = action; | ||
| }); |
There was a problem hiding this comment.
I'm only sorta confident the columnStartAction changes here are correct. Remember, friends don't let friends use postfix increment in complex expressions. (Ideally ever.)
The rearranging is required because you can't do stuff to ref params from inside a closure.
bdach
force-pushed
the
fix-mania-notes-disappearing
branch
from
a898da3 to
15a8cfe
Compare
smoogipoo
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC. Would close #30639.
Not too sold on this myself, but it appears to work well enough for a hack.
Options I also considered but didn't end up going through with:
ManiaHitObject(smelled of twisting gameplay code to editor needs)DrawableEditorRulesetWrapperto press keys 1ms late instead (no easy entry point to do this, would need to create yet another virtual onRulesetrather than leveraging existing structures, even though this change ended up doing two levels of virtuals)