Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust osu!taiko constant scroll algorithm to match expectations #30624

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

Hiviexd
Copy link
Member

@Hiviexd Hiviexd commented Nov 14, 2024

resolves #28566

my explanation is in the replies but I'll repost here for visibility:


it seems like the Constant ScrollVisualisationMethod results in a 60BPM scroll speed by default (hence a 4x multiplier existing, which bumped scroll speed to 240 BPM), so adjusting this line to the following would fix this:

-             double multiplier = VisualisationMethod == ScrollVisualisationMethod.Constant ? 4 * Beatmap.Difficulty.SliderMultiplier : 1;
+             double multiplier = VisualisationMethod == ScrollVisualisationMethod.Constant ? (Beatmap.BeatmapInfo.BPM * Beatmap.Difficulty.SliderMultiplier) / 60 : 1;

I've tested the above and on a beatmap with 1.4 base SV and no scroll speed changes, and toggling between Constant and Overlapping ScrollVisualisationMethod results in identical visuals, which should be the expected behavior.

bNNh2eV.mp4

@peppy
Copy link
Member

peppy commented Nov 15, 2024

Going to assume you know best here 👍

@peppy peppy merged commit b3b1868 into ppy:master Nov 15, 2024
10 checks passed
@Hiviexd Hiviexd deleted the fix-constant-algorithm-scroll-speed branch December 11, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Taiko Constant Speed mod can change base scroll speed for map
2 participants