Adjust osu!taiko constant scroll algorithm to match expectations #30624
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #28566
my explanation is in the replies but I'll repost here for visibility:
it seems like the
Constant
ScrollVisualisationMethod
results in a 60BPM scroll speed by default (hence a 4x multiplier existing, which bumped scroll speed to 240 BPM), so adjusting this line to the following would fix this:I've tested the above and on a beatmap with 1.4 base SV and no scroll speed changes, and toggling between
Constant
andOverlapping
ScrollVisualisationMethod
results in identical visuals, which should be the expected behavior.bNNh2eV.mp4