Do not show timing distribution graph in offset control if there's not enough timed hits #30622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t enough timed hits Intended to address concerns raised in ppy#30620 (comment).
|
Adding to #30620 (comment), this also happens when you hit a slider with classic mod and then miss everything else (which is what probably happened in the original issue) |
smoogipoo
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to address concerns raised in #30620 (comment).
I'm intentionally not using the version of the check from
osu/osu.Game/Screens/Ranking/Statistics/HitEventTimingDistributionGraph.cs
Line 61 in d08c8ae
since that version of the conditional is special and fixes a purely visual issue visible on the results screen (#24274).