Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NaN PP counter values while SR is 0 #30618

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Fix NaN PP counter values while SR is 0 #30618

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce818f5
Fix NaN PP values when SR is 0
Natelytle Nov 14, 2024
2ea2e5f
Be doubly careful
Natelytle Nov 14, 2024
d0e793a
More correct but not too important
Natelytle Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions osu.Game/Rulesets/Difficulty/Skills/StrainSkill.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@ public virtual double CountTopWeightedStrains()
return 0.0;

double consistentTopStrain = DifficultyValue() / 10; // What would the top strain be if all strain values were identical

if (consistentTopStrain == 0)
return ObjectStrains.Count;

// Use a weighted sum of all strains. Constants are arbitrary and give nice values
return ObjectStrains.Sum(s => 1.1 / (1 + Math.Exp(-10 * (s / consistentTopStrain - 0.88))));
}
Expand Down