-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust a beatmaps offset automatically after each play #30586
Open
Inconsist
wants to merge
21
commits into
ppy:master
Choose a base branch
from
Inconsist:Adjust_offset
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ae5f839
adding logic to adjust offset after ach play
Inconsist ff93d91
adding menu/settings requirements
Inconsist 8ddf79a
xml doc adjustment
Inconsist 795c0a6
Refactored to more meaningful names added comments to explain calcula…
Inconsist d1acdc9
update to name after changes.
Inconsist 0c06b74
fixed problem with codefactor
Inconsist a606bef
Merge branch 'ppy:master' into Adjust_offset
Inconsist 08d18b8
added checkbox on the in game overlay menu that appears on start/rest…
Inconsist 0688853
Merge remote-tracking branch 'origin/Adjust_offset' into Adjust_offset
Inconsist 76d7343
Merge branch 'ppy:master' into Adjust_offset
Inconsist 4432e95
try to fix single thread crashing
Inconsist 8f017c2
Merge remote-tracking branch 'origin/Adjust_offset' into Adjust_offset
Inconsist f11ba0a
Merge branch 'ppy:master' into Adjust_offset
Inconsist 402aea4
conform with codestyle in similar files.
Inconsist 715a0f3
reverting switch to if statements.
Inconsist 76ba64a
Merge remote-tracking branch 'origin/Adjust_offset' into Adjust_offset
Inconsist c994448
Merge branch 'ppy:master' into Adjust_offset
Inconsist a9e0856
Merge branch 'ppy:master' into Adjust_offset
Inconsist ab6d06c
Adjust messaging to be more explicit
peppy 9a290bb
Remove setting from player loader
peppy 8703f59
removed leftover unsused checkbox from the loader screen
Inconsist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure this makes good sense, but without attempting to understand the consequences, I'm curious if there's a reason not to always use this algorithm even when the user presses the adjust button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think anything speaks against this per se. But it might just lead to situations where the player feels like the offset should have been way bigger, and is confused why it only says something like 0.8ms.
The button press is a conscious choice you make after every play, so I think displaying the true hit error average here is more genuine towards the player.
You can always choose not to apply an offset you know resulted from you playing poorly.
In my opinion when using the automation the safeguard is needed, but the player should choose themself when using the button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair. Might be good to include this kind of explanation inline to give more context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I made a comment that leads any reader to the discussion where the calculation is explained in more detail. I didn't want to write such long comments since they say less than the image.
If you mean giving more context to the player, the setting name is already quite long, I couldn't think of a better way to name the setting for now, any ideas are appreciated.