Split diffcalc workflow to add concurrency group #30566
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diffcalc runner currently dies when many runs are queued up because they're running in lock-step and each one eventually manages to extract scores/beatmaps prior to other runs having completed.
The plan of attack here is to split the workflow into two pieces: the main
diffcalc.yml
and a new reusable_diffcalc_processor.yml
workflow with concurrency applied that effectively locks for the duration of the workflow on the self-hosted runner.I've tried to make as minimal changes as possible for now. Most of the changes are around the "environment" job because there's a level of indirection for data like the PR URL, comment text, and dispatch inputs.
Here's a dispatched run: https://github.com/ppy/osu/actions/runs/11756297523
Keep in mind I haven't tested the PR/comment part of this though I've made a good effort to ensure it should work. I'm hoping this can be first merged with minimal friction and I can commit directly to master any follow-up fixes that need to be done (it's hard to test that part out in full...).