Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split diffcalc workflow to add concurrency group #30566

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Nov 9, 2024

The diffcalc runner currently dies when many runs are queued up because they're running in lock-step and each one eventually manages to extract scores/beatmaps prior to other runs having completed.

The plan of attack here is to split the workflow into two pieces: the main diffcalc.yml and a new reusable _diffcalc_processor.yml workflow with concurrency applied that effectively locks for the duration of the workflow on the self-hosted runner.

I've tried to make as minimal changes as possible for now. Most of the changes are around the "environment" job because there's a level of indirection for data like the PR URL, comment text, and dispatch inputs.

Here's a dispatched run: https://github.com/ppy/osu/actions/runs/11756297523

Keep in mind I haven't tested the PR/comment part of this though I've made a good effort to ensure it should work. I'm hoping this can be first merged with minimal friction and I can commit directly to master any follow-up fixes that need to be done (it's hard to test that part out in full...).

@@ -0,0 +1,250 @@
name: "🔒diffcalc (do not use)"
Copy link
Contributor Author

@smoogipoo smoogipoo Nov 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done this because gha doesn't have any way to reorder/organise workflows, and this at least pushes it to the bottom of the list: https://github.com/smoogipoo/osu/actions/workflows/diffcalc.yml

@peppy peppy merged commit f897ab5 into master Nov 11, 2024
14 of 17 checks passed
@peppy peppy deleted the improve-diffcalc-workflow branch November 11, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants