Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DifficultyCalculationUtils #30536

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

stanriders
Copy link
Member

This refactors some common confusion points (strain to bpm conversions, circle-size-based distances) and adds a common sigmoid implementation. Sigmoid curves were kept the same which resulted in some unusual exponents like ex-2e, but values shouldn't change at all (from my limited testing they did not)

Copy link
Member

@tsunyoku tsunyoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on code/concept. @smoogipoo sheets to verify no changes?

@smoogipoo
Copy link
Contributor

!diffcalc
RULESET=osu

@smoogipoo
Copy link
Contributor

!diffcalc
RULESET=taiko

@smoogipoo
Copy link
Contributor

!diffcalc
RULESET=mania

Copy link

Copy link

Copy link

Copy link

@smoogipoo
Copy link
Contributor

Seems okay. I suppose the osu! pp losses are expected from the refactoring (@stanriders)?

https://docs.google.com/spreadsheets/d/1yx1fERXXk6HbhCzwVseuyTSUGlXVOP13AHmfEwL2Ke0/edit

@stanriders
Copy link
Member Author

Seems okay. I suppose the osu! pp losses are expected from the refactoring (@stanriders)?

https://docs.google.com/spreadsheets/d/1yx1fERXXk6HbhCzwVseuyTSUGlXVOP13AHmfEwL2Ke0/edit

I'm not really sure what those are - all changes osu-side are in the diffcalc, but SR didn't change for any map and pp changed only for 3 pretty generic maps. It's probably some rounding errors from the sigmoid changes though, so I'd say its a non-issue

It is weird though how all of those are pretty much exactly -0.1 pp regardless of difficulty, maybe something in the sheet processing writing numbers in a weird way?

@smoogipoo
Copy link
Contributor

+/- 0.1 is the minimum for changes to be added to the sheet for PP and SR, +/- 0 for score.

Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoogipoo smoogipoo merged commit 60d45d4 into ppy:master Nov 13, 2024
8 of 9 checks passed
@stanriders stanriders deleted the add-diffcalc-helpers branch November 13, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Pending Deploy
Development

Successfully merging this pull request may close these issues.

3 participants