-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DifficultyCalculationUtils
#30536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on code/concept. @smoogipoo sheets to verify no changes?
!diffcalc |
!diffcalc |
!diffcalc |
Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/11772319963 |
Seems okay. I suppose the osu! pp losses are expected from the refactoring (@stanriders)?
|
I'm not really sure what those are - all changes osu-side are in the diffcalc, but SR didn't change for any map and pp changed only for 3 pretty generic maps. It's probably some rounding errors from the sigmoid changes though, so I'd say its a non-issue It is weird though how all of those are pretty much exactly -0.1 pp regardless of difficulty, maybe something in the sheet processing writing numbers in a weird way? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This refactors some common confusion points (strain to bpm conversions, circle-size-based distances) and adds a common sigmoid implementation. Sigmoid curves were kept the same which resulted in some unusual exponents like
ex-2e
, but values shouldn't change at all (from my limited testing they did not)