Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix effect point scroll speeds below 0.1x not being encoded properly #30509

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Nov 5, 2024

Add failing test case

Demonstrates failure in LegacyBeatmapEncoderTest.

Fix LegacyBeatmapEncoderTest swapping expected/actual values around

Was making test output look confusing.

Fix effect point scroll speeds below 0.1x not being encoded properly

Closes #30472.

Caused by mismatching bounds between

public readonly BindableDouble ScrollSpeedBindable = new BindableDouble(1)
{
MinValue = 0.01,
MaxValue = 10
};

and

public readonly BindableDouble SliderVelocityBindable = new BindableDouble(1)
{
MinValue = 0.1,
MaxValue = 10
};

@bdach bdach added ruleset/osu!taiko ruleset/osu!mania area:beatmap-parsing .osu file format parsing next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! labels Nov 5, 2024
@smoogipoo smoogipoo merged commit 8aed578 into ppy:master Nov 6, 2024
8 of 12 checks passed
@bdach bdach deleted the encode-0-01-svs branch November 6, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:beatmap-parsing .osu file format parsing next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! ruleset/osu!mania ruleset/osu!taiko size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SV timing points less than 0.1x get reverted to 0.1x after saving a beatmap
2 participants