Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search textbox to friends display #30499

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Nov 4, 2024

2024-11-04.14-38-50.mp4

Random user feature request that made sense to me because the same thing is in currently online display.

Yes web doesn't have this, but web is in a browser where you can Ctrl-F. You can't do that in the client.

Design taken out of posterior because I can't be bothered waiting for design cycles for this. cc @ppy/team-design if you want to veto this I guess.

Random user feature request that made sense to me because the same thing
is in currently online display.

Yes web doesn't have this, but web is in a browser where you can Ctrl-F.
You can't do that in the client.

Design taken out of posterior because I can't be bothered waiting for
design cycles for this.
@arflyte
Copy link

arflyte commented Nov 5, 2024

That looks fine. We'll take note of this in the future iteration.

@smoogipoo smoogipoo merged commit fcc6319 into ppy:master Nov 5, 2024
13 checks passed
@bdach bdach deleted the search-friends branch November 5, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants