Increase ducking duration when selecting Mania ruleset #30423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
force-pushed
the
ruleset-selection-duck-tweak
branch
from
00318cc to
da95a1a
Compare
peppy
reviewed
Nov 6, 2024
| musicController?.DuckMomentarily(500, new DuckParameters { DuckDuration = 0 }); | ||
|
|
||
| // Longer unduck delay for Mania sample | ||
| int unduckDelay = r.NewValue.OnlineID == 3 ? 750 : 500; |
There was a problem hiding this comment.
a bit dodgy but let's just go with it for now.
peppy
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the duck duration to sit better with the new longer Mania selection sample.
Not sure if matching via the ruleset's
OnlineIDis the best approach here?