Add visual effect for slider bar focus state #30410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
focus has to be a border effect. even on the new elements, the hover border thing should instead be focus, and the brightness change should be hover. as it stands this feels back-to-front from expectations. |
|
I'll take a look at fixing this up. |
|
Sure you can change it however you like or make a new PR. I'm not that great at designing UI so I just tried to copy this demo which has the same border effect for hover and focus. The MaterialDesignDemo_iuuS5e8UXr.mp4 |
2 tasks
|
Became a rewrite so opened a separate PR #30413 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
Shows the
HasFocusstate on slider bars using the same glow effect as hover state. When the slider bar has focus and hover state the glow effect stacks.osu._qB7pqDF3BO.mp4
osu._vVzw0uiIEv.mp4