Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix old looping samples not stopping when replacing a SkinnableSound's Samples #30389

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Fix old looping samples not stopping when replacing a SkinnableSound's Samples #30389

merged 1 commit into from
Oct 23, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Oct 22, 2024

Closes #30365.

@bdach bdach added the audio label Oct 22, 2024
@smoogipoo
Copy link
Contributor

smoogipoo commented Oct 23, 2024 •
edited
Loading

I'm having deja-vu.

Is this where we want it? What about PoolableSkinnableSample itself which has very similar code? Maybe it should be in both locations...

@peppy
Copy link
Member

peppy commented Oct 23, 2024

What about PoolableSkinnableSample itself which has very similar code? Maybe it should be in both locations...

There's a theory that this is handled via disposal (triggered by

osu/osu.Game/Skinning/PoolableSkinnableSample.cs

Line 91 in e6f1ec5

sampleContainer.Clear();
)

It's a theory though.

@peppy peppy self-requested a review October 23, 2024 08:28
peppy
peppy approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this breaks something, we're going to find out from a user. Looks fine to my eye.

@peppy peppy merged commit c1453cf into ppy:master Oct 23, 2024
13 checks passed
@bdach bdach deleted the fix-looping-samples-not-stopping branch October 23, 2024 11:09
@MeerukYang
Copy link

Does this also fix #30003 ?

@bdach
Copy link
Collaborator Author

bdach commented Oct 28, 2024

Probably.

@bdach bdach mentioned this pull request Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
audio size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hitsounds loop after being removed from hold notes and then pausing in Mania Editor
4 participants
@bdach @smoogipoo @peppy @MeerukYang