Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeline blueprints sometimes causing crashes due to current placement blueprint becoming unsorted #30377

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Oct 21, 2024

RFC. Closes #30324.

The diff is horrible but I see no better options and I see fixing this bug as pretty urgent since this is a hard crash that can trigger when attempting to do basic operations in the editor.

@bdach bdach added area:editor type:reliability next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! labels Oct 21, 2024
@bdach bdach requested a review from a team October 21, 2024 12:57
Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@peppy peppy merged commit 53a3409 into ppy:master Oct 22, 2024
11 of 13 checks passed
@bdach bdach deleted the very-bad-completely-no-good-comparer branch November 11, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editor next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/M type:reliability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on right click on a taiko hit object
2 participants