Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change convert-to-ternary warning to hint #30373

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Change convert-to-ternary warning to hint #30373

merged 1 commit into from
Oct 21, 2024

Conversation

smoogipoo
Copy link
Contributor

@smoogipoo smoogipoo commented Oct 21, 2024 •
edited
Loading

I brought this up in #27691 (comment), because there are situations (imo more-so than not) where this is very annoying.

bdach
bdach approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@bdach bdach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ternary usage inspections should not be warnings and thus failing CI, because only the simplest conditionals should be using ternaries. Everything more complex than that should be a standard if..else.

@bdach bdach merged commit 3111844 into ppy:master Oct 21, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdach bdach bdach approved these changes

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
area:tooling size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smoogipoo @peppy @bdach