Fix catcher size and hyperdashes indication on adjusting CircleSize #30300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r size and represent hyperdashes incorrectly
|
If circle size is changed after the catcher has already spawned a few trail sprites, they don't get resized properly:
|
|
I've applied the feedback. The only thing I couldn't figure out was an easy way to resize the hyperdash after image effect. |
This one preserves the catcher afterimage, which I'd count as a win.
I seem to have salvaged this via 488fabc. Seems okay otherwise. |
bdach
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TODO that ekr left actually caused two issues when editing the CircleSize of a catch beatmap:
I've fixed this similarly to how we currently apply circle size changes in the osu editor ruleset.