Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect "Prefer metadata in original language" toggle in beatmap deletion dialog #30274

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

shinmorisawa
Copy link
Contributor

This commit fixes #30242. This fix maintains the format from before, but supports the original unicode metadata.

@bdach bdach self-requested a review October 14, 2024 07:52
@bdach bdach changed the title Fix Beatmap Delete Dialog Respect "Prefer metadata in original language" toggle in beatmap deletion dialog Oct 14, 2024
@bdach
Copy link
Collaborator

bdach commented Oct 14, 2024

If you wish to continue PRing changes, then please make sure that you're PRing from a topic branch and not master. This is mentioned in contributing guidelines; please read them if you have not done so yet.

@shinmorisawa
Copy link
Contributor Author

If you wish to continue PRing changes, then please make sure that you're PRing from a topic branch and not master. This is mentioned in contributing guidelines; please read them if you have not done so yet.

ok thank you will do that now. :)

@bdach
Copy link
Collaborator

bdach commented Oct 14, 2024

please do not merge master either unless there are conflicts or specifically instructed to, that is also listed in contributing guidelines

@shinmorisawa
Copy link
Contributor Author

oh ok sorry

@bdach bdach merged commit 639eb7a into ppy:master Oct 14, 2024
5 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete beatmap dialog uses romanised name
2 participants