Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SelectionBox buttons freezing when button is triggered via key event #30206

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

minetoblend
Copy link
Contributor

@minetoblend minetoblend commented Oct 10, 2024

Closes #30204
Supersedes / closes #30205

Didn't consider that keyboard events would actually trigger the button click handler

@bdach
Copy link
Collaborator

bdach commented Oct 10, 2024

#30205?

@minetoblend
Copy link
Contributor Author

minetoblend commented Oct 10, 2024

Oh, looks like olibomby was faster than me. I guess you can pick whichever one you like more then since they both use a different appraoch

Copy link
Contributor

@OliBomby OliBomby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this approach because it's very explicit about what it's doing.

@smoogipoo smoogipoo merged commit 616c2ae into ppy:master Oct 11, 2024
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select box buttons incorrectly freeze on use of hotkey
4 participants