Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ranked date and submitted date filtering to song select #30145

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

WitherFlower
Copy link
Contributor

Implements ranked and submitted filters, following the same logic as the osu-web search, which is described in ppy/osu-web#7358

As a brief summary :

  • Dates in the formats yyyy, yyyy-mm and yyyy-mm-dd are accepted.
  • The valid separators are -, / and .
  • Dates are treated as UTC to keep search results consistent between web and client.
  • I did not add support for hours, minutes and seconds as I don't think it's really useful, but I can make the addition if deemed necessary

This is especially useful now that #29862 has been merged, as all players will have correct ranked/submitted date values in their databases starting from next release.

P.S. : This is my first PR here, so please tell me if I horribly messed up some step of the process.

@WitherFlower WitherFlower force-pushed the ranked-date-filtering branch 2 times, most recently from 1fdc4cd to 965f1c2 Compare October 9, 2024 21:03
osu.Game/Screens/Select/FilterQueryParser.cs Outdated Show resolved Hide resolved
osu.Game/Screens/Select/FilterQueryParser.cs Outdated Show resolved Hide resolved
osu.Game/Screens/Select/Carousel/CarouselBeatmap.cs Outdated Show resolved Hide resolved
@WitherFlower WitherFlower force-pushed the ranked-date-filtering branch from 965f1c2 to eb2f1d0 Compare October 10, 2024 15:42
@bdach bdach changed the title Add Ranked Date and Submitted Date filtering to song select. Add ranked date and submitted date filtering to song select Oct 11, 2024
@bdach bdach requested a review from peppy October 16, 2024 06:16
Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good 👍

@peppy peppy merged commit dafe8d6 into ppy:master Oct 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants