Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to centre editor grid to current hit object #30069

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented Oct 1, 2024

Just a quick one. Maybe needs a keyboard shortcut? Maybe also in context menu? But also probably fine to get this in as a first step and see how often it's used?

osu.2024-10-01.at.06.22.22.mp4

Addresses #29818

@bdach bdach self-requested a review October 1, 2024 09:01
bdach added 2 commits October 1, 2024 11:12
Did not match the expandable button in distance snap toolbox.
@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 1, 2024
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, but I've had to apply a few fixes. Please check them whenever convenient.

@peppy peppy merged commit 8ea1ff5 into ppy:master Oct 1, 2024
8 of 9 checks passed
@peppy peppy deleted the grid-to-current-object branch October 1, 2024 10:35
@OliBomby
Copy link
Contributor

OliBomby commented Oct 1, 2024

I'm surprised this got added while we have #26313 which addresses the exact same concern and more.

@peppy
Copy link
Member Author

peppy commented Oct 1, 2024

It might be something we can remove if the other PR gets to fruition. I didn't realise that one could snap to hitobjects so saw this as something which can coexist with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants