-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freeze select box buttons position on press #29950
Freeze select box buttons position on press #29950
Conversation
I can see the issue and I see some merit to this solution but I'm not 100% on the end result. The buttons moving away on hover loss feels particularly awkward. At this point I have to wonder if these buttons have to / should be attached to the selection box. Maybe they should be somewhere off the playfield to stop visually obstructing things...? @peppy curious to hear your thoughts on this |
I agree that the jump back looks a bit jarring the way it suddenly teleports back right now. Do you think animating the position change would be a way to address this? |
I was going to suggest that but figured it'd be (a) probably rather annoying to do and (b) not even sure it'd look good. You could try, though. |
I think animating them (if it's not too much effort) with a 300 ms OutQuint should look quite good. Otherwise, as-is is fine. I agree with the UX. |
The anchor/origin changes make it a bit tricky, but I think it should be doable. At the very least it'll be a good test for how much I learned about o!f layout internals from porting it to js. Do you want the transition to happen on every reposition or only after you stop hovering? |
Only in the special case. But if it's more than a few lines I'd not bother. |
I managed to get it working, not sure if this is a good way of doing it though. 2024-09-24.16-37-40.mp4 |
@peppy gonna wait for your cross-check of the animation here, unless you decide you don't want to do one |
I think it looks fine. Maybe it could also animate when anchor changes, but not too fussed. |
Will freeze the position of the
SelectBox
buttons in place when one of the buttons was clicked until the clicked button is no longer hovered. This ensures that buttons can be pressed repeatedly without having to reposition the mouse on every click.Especially when rotating the selection by 90 degrees, the buttons moving around on each press was a major pain point for me since I often wanna rotate by 180 degrees and just wanna double click the button for that.
After:
2024-09-21.14-57-25.mp4
Before:
2024-09-21.14-58-39.mp4