Adjust played song select filter to accept a boolean value
#29644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems much better direction wise 👍 . I guess we just need to decide if we alias the silly stable one ( |
|
I'll point out that the change to |
peppy
approved these changes
Aug 29, 2024
|
Aware, but personally I'm happy to break this for something that makes more sense. A next step would be exposing these to the user so they can actually find them without resorting to a wiki or otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes / closes #29638
Resolves Resolves #29568
Currently, the
playedfilter is an acronym forlastplayed. This PR changes it to be a boolean value.played=0/played=false-> beatmap has never been played.played=1/played=true-> beatmap has been played sometime.