Allow seeking via music controller overlay on more screens #29576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In testing I can't find a reason for this to exist. Blaming back shows that it existed before we had `AllowTrackControl` and was likely being used as a stop-gap measure to achieve the same thing. It's existed since over 6 years ago. Let's give removing it a try to fix some usability concerns? Closes ppy#29563.
|
I'm not sure this is going to fly. Tentative list of screens that specify
Have you tested all of these? |
|
I tested results and loader and all seemed okay, did not test editor (overlooked). Sounds sketch, will test now. |
|
Editor does seem fine due to |
|
Seeking on results screen looks a bit bugged if the track has stopped at end: 2024-08-27.12-26-46.mp4Not super sure I want to block this PR on that, but yeah. |
|
Dunno, that looks like a bass frame delay bug, since the game looks like it's trying to play the track. I'd probably just brush it under the rug for now.. |
bdach
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing I can't find a reason for this to exist. Blaming back shows that it existed before we had
AllowTrackControland was likely being used as a stop-gap measure to achieve the same thing. It's existed since over 6 years ago.Let's give removing it a try to fix some usability concerns?
Closes #29563.