Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "leftover files" notification when migration partly fails #29562

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented Aug 22, 2024

People were deleting files they shouldn't, causing osu! to lose track of where the real user files are.

For now let's just keep things simple and not let the users know that some files got left behind. Usually the files which are left behind are minimal and it should be fine to leave this up to the user.

Closes #29505.

People were deleting files they shouldn't, causing osu! to lose track of
where the real user files are.

For now let's just keep things simple and not let the users know that
some files got left behind. Usually the files which are left behind are
minimal and it should be fine to leave this up to the user.

Closes ppy#29505.
@peppy peppy added the realm deals with local realm database label Aug 22, 2024
@bdach bdach self-requested a review August 22, 2024 07:53
bdach
bdach previously approved these changes Aug 22, 2024
@bdach bdach merged commit b3e961f into ppy:master Aug 22, 2024
13 checks passed
@peppy peppy deleted the remove-migration-leftover-message branch August 23, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
realm deals with local realm database size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change folder location doesn't work
2 participants