Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make break periods in bottom timeline transparent #29445

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

OliBomby
Copy link
Contributor

closes #29339

Break periods in the bottom timeline are also transparent in stable. I chose the color and alpha on what looked right to me.

rider64_XnX1cVE8o8

@bdach
Copy link
Collaborator

bdach commented Aug 19, 2024

Not sure. I'd probably also accept kiai markers showing on top of break markers?

Seems probably fine to me, but I'm not merging without @peppy crosscheck since he has his opinions on how the bottom timeline should look that I'm not confident of being able to match.

bdach
bdach previously approved these changes Aug 19, 2024
@bdach bdach requested a review from peppy August 19, 2024 11:24
@peppy
Copy link
Member

peppy commented Aug 19, 2024

I'd probably also accept kiai markers showing on top of break markers?

I'd prefer this. I'll have a play with it.

@OliBomby
Copy link
Contributor Author

I'd probably also accept kiai markers showing on top of break markers

We have to be careful to not create the inverse problem of breaks being hidden by kiai times on the bottom timeline.

@peppy
Copy link
Member

peppy commented Aug 20, 2024

I've updated the visuals of this a bit:

2024-08-20 17 46 31@2x

@bdach sanity sign-of please.

@bdach bdach merged commit f0ddb6d into ppy:master Aug 20, 2024
13 checks passed
@OliBomby OliBomby deleted the transparent-break branch October 1, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Break periods hide kiai times on the bottom timeline
4 participants