Fix occasionally ChatOverlay test failures due to RNG usage
#29365
GitHub Actions / Test Results (Windows, MultiThreaded)
failed
Aug 9, 2024 in 0s
10325 passed, 1 failed and 74 skipped
❌ TestResults-Windows-MultiThreaded.trx
10400 tests were completed in 2844s with 10325 passed, 1 failed and 74 skipped.
| Test suite | Passed | Failed | Skipped | Time |
|---|---|---|---|---|
| osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations | 11✅ | 1❌ | 21s |
❌ osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations
✅ TestBestRulesetIsRecommended
✅ TestBestRulesetIsRecommended
✅ TestConstructor
✅ TestConstructor
✅ TestCorrectStarRatingIsUsed
❌ TestCorrectStarRatingIsUsed
"recommended beatmap displayed" timed out
✅ TestCurrentRulesetIsRecommended
✅ TestCurrentRulesetIsRecommended
✅ TestPresentedBeatmapIsRecommended
✅ TestPresentedBeatmapIsRecommended
✅ TestSecondBestRulesetIsRecommended
✅ TestSecondBestRulesetIsRecommended
Annotations
Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs
github-actions / Test Results (Windows, MultiThreaded)
osu.Game.Tests.Visual.SongSelect.TestSceneBeatmapRecommendations ► TestCorrectStarRatingIsUsed
Failed test found in:
TestResults-Windows-MultiThreaded.trx
Error:
"recommended beatmap displayed" timed out
Raw output
"recommended beatmap displayed" timed out
at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in D:\a\osu\osu\osu.Game\Tests\Visual\OsuTestScene.cs:line 539
at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)
Loading